Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expo instructions #6849

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Update expo instructions #6849

merged 2 commits into from
Aug 18, 2024

Conversation

kadikraman
Copy link
Contributor

What, How & Why?

1. use npx expo install instead of npm install

npx expo install will use your configured package manager, npm install will use npm so won't work if you're using a different package manager

2. update expo go instructions

The instructions said "consider using development build" which implies there are other ways to get it to work within Expo Go, which isn't the case. This adds a small tweak to make it clearer what to do next.

@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 18, 2024

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @kadikraman. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@kadikraman kadikraman changed the title Update expo instrcutions Update expo instructions Aug 18, 2024
@kadikraman
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Aug 18, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 18, 2024

The cla-bot has been summoned, and re-checked this pull request!

kraenhansen
kraenhansen approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @kadikraman!

@kraenhansen kraenhansen merged commit e0645a3 into realm:main Aug 18, 2024
21 of 26 checks passed
@kraenhansen kraenhansen self-assigned this Aug 18, 2024
@kadikraman kadikraman deleted the @kadikraman/expo-instructions branch August 19, 2024 11:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees

@kraenhansen kraenhansen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kadikraman @kraenhansen